chore: handle ineligible_guides in guides fetch response#844
Merged
thomaswhyyou merged 4 commits intomainfrom Feb 13, 2026
Merged
chore: handle ineligible_guides in guides fetch response#844thomaswhyyou merged 4 commits intomainfrom
thomaswhyyou merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
This was referenced Feb 2, 2026
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-1
branch
from
3ca6b2e to
bfd9122
Compare
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-4
branch
from
9c6bd46 to
34821df
Compare
thomaswhyyou
changed the base branch from
thomas-kno-11142-sdk-guide-toolbar-v2-poc-1
to
graphite-base/844
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-4
branch
from
34821df to
7963ad8
Compare
thomaswhyyou
changed the base branch from
graphite-base/844
to
thomas-kno-11142-sdk-guide-toolbar-v2-poc-1
thomaswhyyou
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
thomaswhyyou
requested review from
a team,
andy-knock,
connorlindsey and
kylemcd
and removed request for
a team
connorlindsey
approved these changes
Feb 4, 2026
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-1
branch
from
8c99027 to
9243f08
Compare
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-4
branch
from
2c0551f to
52ff4da
Compare
Base automatically changed from
thomas-kno-11142-sdk-guide-toolbar-v2-poc-1
to
main
February 12, 2026 22:21
thomaswhyyou
force-pushed
the
thomas-kno-11142-sdk-guide-toolbar-v2-poc-4
branch
from
52ff4da to
ce42ed9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 68.41% 68.45% +0.04%
==========================================
Files 193 193
Lines 8041 8053 +12
Branches 1062 1066 +4
==========================================
+ Hits 5501 5513 +12
Misses 2515 2515
Partials 25 25
|
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the guide client so it reads
ineligible_guidesfrom the fetch endpoint response and stores into the client state store, to prep ahead of the toolbar changes in downstream PRs.As a reminder, this new field was introduced recently (here) to expose "ineligible markers", a minimal payload that explains which guide was evaluated ineligible for what reason. This information was previously inaccessible to the outside callers, but we want to surface it in the guide toolbar.